On Thu, 9 Feb 2023 15:07:01 GMT, Maurizio Cimadamore <[email protected]>
wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> AttributeElement.Kind removal (#48)
>
> src/java.base/share/classes/jdk/internal/classfile/instruction/TypeCheckInstruction.java
> line 39:
>
>> 37:
>> 38: /**
>> 39: * Models an {@code instanceof} or {@code checkcast} instruction in the
>> {@code
>
> This seems to model both `instanceof` and `checkcast`. The latter seems to
> overlap partially with `ConvertInstruction`.
`instanceof` and `checkcast` are both very similar type checking instructions.
They have the same length, the same format, the same specification of the
instruction parameters and almost the same behaviour.
All members of `ConvertInstruction` have no instruction parameters and source
and target of conversion is identified from the opcode. Also the instructions
do conversions and not type checking.
I don't see any averlap.
-------------
PR: https://git.openjdk.org/jdk/pull/10982
