On Tue, 17 Jan 2023 17:41:33 GMT, Jim Laskey <jlas...@openjdk.org> wrote:
>> Can I please get a review for this change which proposes to fix the issue >> reported in https://bugs.openjdk.org/browse/JDK-8206890? >> >> The `jlink` command allows a `--endian` option to specify the byte order in >> the generated image. Before this change, when such a image was being >> launched, the code would assume the byte order in the image to be the native >> order of the host where the image is being launched. That would result in >> failure to launch java, as noted in the linked issue. >> >> The commit in this PR, changes relevant places to not assume native order >> and instead determine the byte order by reading the magic bytes in the image >> file's header content. >> >> A new jtreg test has been added which reproduces the issue and verifies the >> fix. > > src/java.base/share/classes/jdk/internal/jimage/ImageHeader.java line 226: > >> 224: ByteOrder altByteOrder = bb.order() == ByteOrder.BIG_ENDIAN >> 225: ? ByteOrder.LITTLE_ENDIAN : ByteOrder.BIG_ENDIAN; >> 226: bb.flip(); > > Don't you just want to rewind here? Hello Jim, you are right `rewind()` would be a better API to use here. ------------- PR: https://git.openjdk.org/jdk/pull/11943
