On Fri, 12 Aug 2022 14:52:23 GMT, Brian Burkhalter <b...@openjdk.org> wrote:

> On Windows, suppress failure if the total space indicated by `df` is less 
> than `FileStore::getTotalSpace` and the free space indicated by `df` equals 
> `FileStore::getUnallocatedSpace`.

test/jdk/java/io/File/GetXSpace.java line 244:

> 242:                 // reported by df might be less that the actual total 
> space in
> 243:                 // the store, but the free space should be the same.
> 244:                 if (!(Platform.isWindows() && ts > s.total && fs == 
> s.free())) {

Unsure of the conditional here, in particular whether `fs == s.free()` is 
needed. Also, when failure is suppressed here, an informational print might be 
useful.

-------------

PR: https://git.openjdk.org/jdk/pull/9856

Reply via email to