On Fri, 17 Jun 2022 15:01:16 GMT, Jorn Vernee <jver...@openjdk.org> wrote:

>> Adam Sotona has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Update test/jdk/java/lang/constant/ClassDescTest.java
>>   
>>   Co-authored-by: Jorn Vernee <jornver...@users.noreply.github.com>
>
> test/jdk/java/lang/constant/ClassDescTest.java line 136:
> 
>> 134: 
>> 135:         List<ClassDesc> stringClassDescs = 
>> Arrays.asList(ClassDesc.ofDescriptor("Ljava/lang/String;"),
>> 136:                                                         
>> ClassDesc.ofInternalName("java/lang/String"),                                
>>                         ClassDesc.of("java.lang", "String"),
> 
> Looks like an accidental duplicate of `ClassDesc.of("java.lang", "String")`?
> Suggestion:
> 
>                                                         
> ClassDesc.ofInternalName("java/lang/String"),

Thanks for pointing it out, I had to watch my screen quite a long time to see 
it is hidden behind the corner :)

-------------

PR: https://git.openjdk.org/jdk/pull/9201

Reply via email to