On Mon, 14 Feb 2022 21:24:47 GMT, Mandy Chung <mch...@openjdk.org> wrote:
>> Joe Darcy has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Respond to review feedback explicitly stating returned sets are immutable. > > I'm glad to see this proposal moving along to better model the JVM access > flags. I think it's right to define a better enhanced API than updating > `java.lang.reflect.Modifier` (which is indeed inadequate to provide the > sufficient context for modeling). > > I also think `AccessFlag` is a good class name that well represents the > `access_flags` in a class file per the JVM spec. @mlchung, @asotona, @RogerRiggs and others: I've synced the current version of the API changes in the CSR: https://bugs.openjdk.java.net/browse/JDK-8281660 Please review the CSR so it can go through the first phase of the process. (I suspect some additional refinement will be needed for the mapping of Class modifiers once some more test are written.) @asotona , I've corrected bugs in the mapping of the flags of various module parts (opens, requires, etc.). Please use the latest version for any additional testing. Thanks. ------------- PR: https://git.openjdk.java.net/jdk/pull/7445
