On Thu, 3 Dec 2020 09:58:16 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> The attribute_length of known ModuleXXXX attributes in the module-info.class >> is currently ignored. It should be checked and the class rejected if the >> attribute length doesn't exactly match the length of the info in the >> attribute. >> >> There are several ways to fix this. I initially limited the reading of the >> attribute_info to the attribute length but this resulted in confusing >> exception messages as the attribute appears truncated. The exception >> messages are clearer when it checks that the attribute length corresponds to >> the number of bytes read. > > Alan Bateman has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains 11 additional > commits since the last revision: > > - Restructure check to make it more obvious that it doesn't overflow > - Merge > - Merge > - Merge > - Trailing whitespace > - Expand test to Module attribute > - Merge > - Test cleanup > - Add test > - Merge > - ... and 1 more: > https://git.openjdk.java.net/jdk/compare/03216be8...f15dbb1b Marked as reviewed by dfuchs (Reviewer). src/java.base/share/classes/jdk/internal/module/ModuleInfo.java line 288: > 286: > 287: long newPosition = in.count(); > 288: if ((newPosition - initialPosition) != length) { LGTM! Thanks for making the change. ------------- PR: https://git.openjdk.java.net/jdk/pull/1407
