Hi Philippe,
On 22/09/2020 3:57 pm, Philippe Marschall wrote:
Hello
I am looking for a sponsor for JDK-8138732 [1]. The ready to integrate
PR is here [2].
Sorry I can't volunteer to sponsor this.
Changes between the current code and the reviewed code:
- I removed the jdk.internal export to jdk.jfr, that was a review comment.
- I had to rebase and resolve a merge conflict with JDK-8243066.
@marschall marschall force-pushed the marschall:JDK-8138732 branch
from 1c9dd9d to 5c49560 1 hour ago
Please do not force-push anything as it breaks the commit history in the
PR and renders previous reviews/comments obsolete. There is no way for
the reviewers to see what changed between the commit they reviewed and
the commit now in the PR.
To update to latest changes you should have just merged your branch with
your (up-to-date) local master, committed that merge in your local
branch and then pushed that commit to your Personal Fork. The skara
tooling will flatten the series of commits in a PR into one single
well-formed commit that is pushed to the master branch of the repo.
Thanks,
David
-----
[1] https://bugs.openjdk.java.net/browse/JDK-8138732
[2] https://github.com/openjdk/jdk/pull/45
Cheers
Philippe
