Thanks Alan, I'll push this after running through jdk-submit. I'm preparing another patch for some further cleanup regarding canonicalize. But it won't get rid of the call from JPLIS.
Best regards Christoph > -----Original Message----- > From: Alan Bateman <alan.bate...@oracle.com> > Sent: Dienstag, 29. Oktober 2019 15:33 > To: Langer, Christoph <christoph.lan...@sap.com>; hotspot-runtime- > d...@openjdk.java.net; Java Core Libs <core-libs-dev@openjdk.java.net> > Cc: Schmelter, Ralf <ralf.schmel...@sap.com> > Subject: Re: RFR (S) 8232168: Fix non wide char canonicalization on Windows > > On 23/10/2019 14:26, Langer, Christoph wrote: > > Hi Alan, > > > >> I have this on my list to look at. I think we'll need to figure out a > >> path to separate the usages (the JPLIS agent usage is technical debt, we > >> should have addressed that issue a long time ago). > > I agree that it's a good thing to explore how the different usages of calls > > to > canonicalize could be disentangled. However, can't we defer that to another > item? This one seems like a straightforward bugfix to me, with some cleanup > attached. And I've prepared some more cleanup in that area already which is > dependent on this fix - so I'd appreciate if this wouldn't be procrastinated > too > much :) > I went through the change and they look okay to me (much smaller than I > was expecting). I think we will need to figure out a solution for the > JPLIS agent at some point because it shouldn't be using functions in > libjava (having the VM use the function isn't too bad I suppose). > > -Alan
