There really aren't any tests for overridable resources in packages, the
mechanism is only tested by testing the one resource that is
overriddable in app-image build, the app icon.
This the second resources overridable in windows packages, (the
post-install script is the other).
On Linux (other than icons) there seem to be 3 overridable resources,
and on macos there seem to be 4 each for dmg and pkg packages.
In most cases, even though the automation can create packages with the
overridden resources, we will not be able to automatically verify the
custom resources are used.
This is a good project for our upcoming test sprint: To develop
automated tests that generate packages with each of these resources
overridden, and instructions to manually verify the custom resource was
used.
/Andy
On 10/22/2019 2:57 PM, Alexey Semenyuk wrote:
Looks good.
It would be good to have a test for this change as a part of this fix
or as a follow up CR.
- Alexey
On 10/22/2019 2:50 PM, Andy Herrick wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
use createResource() to get an over-ridable resource.
[1] https://bugs.openjdk.java.net/browse/JDK-8232723
[2] http://cr.openjdk.java.net/~herrick/8232723/webrev.01
/Andy
