Hi Remi,
Point taken about consistency.
I'm concerned about code that is unnecessarily fragile due to
unnecessary and unexpected optimizations.
$.02, Roger
On 7/14/2017 2:01 PM, Remi Forax wrote:
I do not like the equals in the constructor of Charset given that in
StandardCharsets, == is used.
I think the constructor of Charset should use == and a comment should be added
explaining why it's valid to use == like in StandardCharsets.
cheers,
Rémi
----- Mail original -----
De: "Roger Riggs" <roger.ri...@oracle.com>
À: "core-libs-dev" <core-libs-dev@openjdk.java.net>
Envoyé: Vendredi 14 Juillet 2017 19:12:09
Objet: Re: [10] RFR: 8184665: Skip name and alias checks for standard Charsets
+1,
Thanks, Roger
On 7/14/2017 1:03 PM, Claes Redestad wrote:
Hi Roger,
On 2017-07-14 18:25, Roger Riggs wrote:
Hi Claes,
Using == with references always looks a bit suspicious in the source
code, especially strings.
Since the first thing in equals() is the identity check, I'd suggest
using .equals for the comparisons.
Sure, there's no significant performance difference, even in
interpreted mode:
http://cr.openjdk.java.net/~redestad/8184665/jdk.01/
/Claes
