Hi Lance,
The change looks good.
Noticed two minor things in StatementTests.java:
A typo at 52 * Validate a NullPointerException is thrown is the
string passed to. The 2nd "is" was meant to be "if"
For test03, param "expected" may be not needed.
Best,
Joe
On 10/20/2015 1:19 PM, Lance Andersen wrote:
Hi,
Looking for a reviewer for
http://cr.openjdk.java.net/~lancea/8139056/webrev.00/.
This change Adds two convenience methods to Statement.java:
- enquoteLiteral which returns a string enclosed in single quotes where all occurrences of a single quote are converted to two single quotes
- enquoteIdentifier returns a SQL identifier
The CCC has been approved.
Best
Lance
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
[email protected]
