On 12/26/14 12:58 AM, Ivan Gerasimov wrote:
Hello!
Some zlib-related tests fail on Solaris hosts, throwing InternalError
with no detailed message.
This might be due to incompatible version of zlib library installed on
the host.
To have a better diagnostics, it is proposed to specifically check for
Z_VERSION_ERROR error code and issue a specific message in that case.
Would you please help review the fix?
BUGURL: https://bugs.openjdk.java.net/browse/JDK-8068230
WEBREV: http://cr.openjdk.java.net/~igerasim/8068230/0/webrev/
Sincerely yours,
Ivan
Hi Ivan,
I'm not sure if it is related to JDK-8008759 which has been fixed in 8.
That one is also related
to the fastdebug binaries, though the issue is more like other native
code calls into jdk zlib code.
As far as I'm aware of those versions of Solaris jdk/jre should be
statically linked with our own
zlib library, it is hard to image that it starts to call a native
platform zlib.
Have you run the test version of jdk/jre with your patch in the similar
testing environment?
Though the patch looks harmless.
-sherman