Hi Kumar,
On 11/14/2013 2:57 PM, Kumar Srinivasan wrote:
Hello,
Please review fixes to the launcher tests, which allows for missing
server vm variant.
All SE platforms have server vm, however Embedded SE systems do
not contain server, most of them have client, thus these
tests needed to be compensated for that.
http://cr.openjdk.java.net/~ksrini/8023978/webrev.0/
In ExecutionEnvironment.java, I understand the fix in line 251 and 257
that address the bug reported. However, I don't understand why doExec
calls to launch javaCmd has to specify "-server" or "client". The jdk
should have a default VM and should the test use that?
TestHelper.java
144 JAVA_JRE_LIB = new File((new File(JAVAHOME)).getParentFile(),
145 (isSDK) ? "jre/lib" : "lib").getAbsolutePath();
If JAVA_HOME is a JDK build (or JRE image), does this give you
an incorrect path? I expect getParentFile() is not needed in that case.
This is copy-n-paste in many places. Does the test require
to run on JDK image (not JDK build)?
189 private static boolean haveVmVariant(String type) {
190 if (isWindows) {
191 File vmDir = new File(JAVA_JRE_BIN, type);
192 File jvmFile = new File(vmDir, JVM_DLL);
jvm.dll should be under jre/bin/client or jre/bin/server as in other
arch, right?
Mandy
