Re: Request for review: 8028149, clean up javac -Xlint errors com.sun.rowset.*

[Joe Darcy]

Hi Lance,

Approved!

Thanks,

-Joe

On 11/11/2013 11:01 AM, Lance Andersen wrote:

Hi,

Need a reviewer to close down these two lint warning in com.sun.rowset.*

$ serialver com.sun.rowset.internal.BaseRow
com.sun.rowset.internal.BaseRow:    static final long serialVersionUID = 
4152013523511412238L;

$ hg status -ma
M src/share/classes/com/sun/rowset/CachedRowSetImpl.java
M src/share/classes/com/sun/rowset/internal/BaseRow.java
ljanders-mac:rowset ljanders$ hg diff
diff -r cb8946eda85b src/share/classes/com/sun/rowset/CachedRowSetImpl.java
--- a/src/share/classes/com/sun/rowset/CachedRowSetImpl.java    Wed Oct 02 
19:13:42 2013 -0400
+++ b/src/share/classes/com/sun/rowset/CachedRowSetImpl.java    Mon Nov 11 
13:46:47 2013 -0500
@@ -541,7 +541,7 @@
          if (rowSetWriter != null) {
              Class<?> c = rowSetWriter.getClass();
              if (c != null) {
-                Class[] theInterfaces = c.getInterfaces();
+                Class<?>[] theInterfaces = c.getInterfaces();
                  for (int i = 0; i < theInterfaces.length; i++) {
                      if 
((theInterfaces[i].getName()).indexOf("TransactionalWriter") > 0) {
                          tXWriter = true;
diff -r cb8946eda85b src/share/classes/com/sun/rowset/internal/BaseRow.java
--- a/src/share/classes/com/sun/rowset/internal/BaseRow.java    Wed Oct 02 
19:13:42 2013 -0400
+++ b/src/share/classes/com/sun/rowset/internal/BaseRow.java    Mon Nov 11 
13:46:47 2013 -0500
@@ -52,6 +52,11 @@
  public abstract class BaseRow implements Serializable, Cloneable {

/**

+ * Specify the serialVersionUID
+ */
+private static final long serialVersionUID = 4152013523511412238L;
+
+/**
   * The array containing the original values for this <code>BaseRow</code>
   * object.
   * @serial
@@ -77,7 +82,7 @@
   * @param idx the index of the element to return
   * @return the <code>Object</code> value at the given index into this
   *         row's array of original values
- * @throws <code>SQLException</code> if there is an error
+ * @throws SQLException if there is an error
   */
      public abstract Object getColumnObject(int idx) throws SQLException;

@@ -90,7 +95,7 @@

   * @param idx the index of the element to be set
   * @param obj the <code>Object</code> to which the element at index
   *              <code>idx</code> to be set
- * @throws <code>SQLException</code> if there is an error
+ * @throws SQLException if there is an error
   */
      public abstract void setColumnObject(int idx, Object obj) throws 
SQLException;
  }