On 10/30/2013 12:42 PM, Brian Burkhalter wrote:
Hi Joe,
So this would be approved provided: 1) "@test" -> "@ test" in the new
tests (add a space between "@" and "test"), and 2) an issue is filed
to convert these back to JTREG tests in JDK 9?
Correct.
Cheers,
-Joe
Thanks,
Brian
On Oct 30, 2013, at 12:35 PM, Joe Darcy wrote:
The code changes look fine. From a correctness standpoint, the tests
look good; however, I still have concerns about the resource usage
even of the tests that don't try to run with an 8 Gb heap since they
do allocate a single object that is about 67 Mb.
Given the point in JDK 8 and its test cycle and the variaty of
devices SE 8 gets run and tested on, I'd be more comfortable making
the remaining test files not jtreg tests in JDK 8 (e.g. "@test" =" "@
test") and filing a follow-up bug to make them jtreg tests in JDK 9
build 01.
