Hi Joel,
The code changes look fine, but I'd like to see some refactoring to the
tests. In particular, please put the logic in
81 try {
82 Class<?> c256 = Class.forName(name256);
83 error++;
84 System.err.println("ERROR: could create " + c256);
85 } catch (ClassNotFoundException e) {
86 ;// ok
87 }
into a method that can be called like failingForName(name, clazz) (or
whatever is appropriate).
Thanks,
-Joe
On 10/9/2013 11:33 AM, Joel Borggren-Franck wrote:
Hi
Please review this spec update and test for getting array classes and
instances of more dimensions than the class file can express or the VM
can handle.
Array.newInstance have a test for arrays of more dimensions than 255,
this patch adds a test for Class.forName as well.
Also the javadoc for Array.newInstance are clarified.
Bug: https://bugs.openjdk.java.net/browse/JDK-7044282
Webrev: http://cr.openjdk.java.net/~jfranck/7044282/webrev.00/
cheers
/Joel
