On 12/08/2013 14:26, harold seigel wrote:
Hi David and Alan,
Thank you for your comments.
The change to the MakeClasslist tool to use TraceClassLoadingPreorder
was made prior to my changes. The following code has been in
MakeClasslist.java for a long time. I was unable to determine who had
made this change or why.
// Understand only "Loading" from
-XX:+TraceClassLoadingPreorder.
// This ignores old "Loaded" from -verbose:class to force
correct
// classlist generation on Mustang.
if (t.equals("Loading")) {
t = tok.nextToken();
t = t.replace('.', '/');
So, I don't know why TraceClassLoadingPreorder was chosen instead of
-verbose:class or TraceClassLoading.
The purpose of my changes are to update the comments to accurately
reflect what the code currently does and to fix a bug in
MakeClasslist.java's 'for' loop where the wrong set of strings is used.
I plan to file a bug stating that the classlists need to be updated
for JDK 8 and assign it to release engineering.
Thanks, Harold
Okay, I see this was changed to use TraceClassLoadingPreorder in 2006
(prior to OpenJDK). Brent might know more about the history.
In any case, the changes looks okay to me and wonderful to hear that the
classlists will be refreshed.
-Alan.
