Hi Iris, On May 30, 2013, at 11:15 AM, Iris Clark wrote:
> This looks fantastic. Thanks for reviewing this. > The changes in Formatter look fine to me. > > I also took a quick look at FormattedFloatingDecimal and am thrilled. I > think you changes have also addressed this bug: > > 5057835- FormattedFloatingDecimal: massive code duplication in J2SE > http://bugs.sun.com/view_bug.do?bug_id=5057835 Thanks for pointing this out. This one http://bugs.sun.com/view_bug.do?bug_id=8008333 actually looks to be a duplicate of that one. > I think you're good to go once you verify that you successfully ran the > regression tests in test/java/util/Formatter. Some time back I already ran all the tests in sun/misc, java/lang, java/math, java/text, java/util/Formatter, java/util/Formattable but will do so once more after correcting the things pointed out by Martin. Thanks, Brian
