Still looks good. :-) On May 8 2013, at 22:27 , Henry Jen wrote:
> On 05/08/2013 09:17 PM, Mike Duigou wrote: >> Looks good to me. >> > > Thanks, we have a minor update to exclude changes for DirectoryStream. > > http://cr.openjdk.java.net/~henryjen/ccc/8006884.2/webrev/ > > A quick review on the update is really appreciated. > > Cheers, > Henry > > >> FaultyFileSystem is I hope something we can reuse in other tests. >> >> Mike >> >> On May 6 2013, at 09:56 , Henry Jen wrote: >> >>> Hi, >>> >>> Updated based on feedback, >>> >>> http://cr.openjdk.java.net/~henryjen/ccc/8006884.1/webrev/ >>> http://cr.openjdk.java.net/~henryjen/ccc/8006884.1/specdiff/ >>> >>> Changed from previous request, >>> >>> 1. DirectoryStream.entries() is renamed to DirectoryStream.stream(). >>> 2. Clarify operating closed stream returned from Files.list as >>> end-of-stream, from Files.walk will throw IllegalStateException, and >>> added test case. >>> >>> Cheers, >>> Henry >> >
