On Apr 26, 2013, at 1:26 AM, Kumar Srinivasan <[email protected]> wrote: > On 4/25/2013 3:53 PM, Mike Duigou wrote: >> The restyling changes obfustucated things a bit but I didn't see anything of >> concern in casual review. >> >> I had hoped to see the updated SmallSet that didn't try to implement >> Iterator directly. > > Remi, Paul and Brian discussed that and struck a deal, maybe Paul/Brain > can shed some light on that. >
If we had stayed with the method names Iterator.forEach and Iterable.forEach (the former was renamed to Iterator.forEachRemaining) then that would have forced a change to SmallSet to fix its rampant layering violation. I don't recall we struck a deal to fix it, but it would be nice if we could do so. Paul.
