On 22.01.2013 19:58, Alan Bateman wrote:
On 22/01/2013 15:45, Anthony Petrov wrote:
Hi Alexey,
The fix looks good from code logic perspective.
I'm only concerned with whether we should use the __try/__except
magic, or would it rather make sense to define:
#define IS_WINVISTA (LOBYTE(LOWORD(::GetVersion())) >= 6)
and guard the call to SHGetKnownFolderPath() with this check? This
seems to be lighter than using the exception handling machinery from
performance perspective, and IMO it would make the code
cleaner/easier to read.
I guess this comes down to whether Windows XP will still be important
when jdk8 ships. I think the current webrev is okay, assuming that
CSIDL_FLAG_DONT_VERIFY is a valid flag for SHGetFolderPathW.
Alexey - I assume you'll test on several different editions of Windows
before you push this.
Yes, I test it on Vista, XP and Win 2000.
Can I push it to JDK8 after?
-Alan.
