On 08/13/2012 06:41 PM, Alan Bateman wrote:
On 13/08/2012 09:26, Jonathan Lu wrote:
Hello Alan,
Thanks for reviewing, I've updated the webrev, could you please take
a look?
http://cr.openjdk.java.net/~luchsh/7190219_2/
:
In the updated webrev, I'm using relGet() to perform the content
checking after put().
And I also updated all the generated Basic<type>.java files using
genBasic.sh.
This looks good to me and thanks for adding the test to to the main
unit test for this area. Do you mind adding the bugID to the list in
Basic.java before you push this? Also, minor nit, can add a space
"//String ops" then it will keep the comments locally consistent (no
need to re-generate the webrev on these points).
-Alan
Thanks, Alan. I've pushed the changes.
Best regards
Jonathan
