On 12/17/2010 11:57 AM, Stuart Marks wrote:
On 12/17/10 6:54 AM, Paul Benedict wrote:
Do it as two commits (one for diamond, the other for line formatting)
that way you can keep the work separate. You may even want 2 Sun
tracking issue in case you need to do several commits under one issue.
The jcheck rules *require* a separate bug ID for each commit.
I'm thinking not only of this particular change, but future changes I
plan to make, where I'll do the diamond conversion other areas of the
JDK, broken down into suitable chunks for easy review. It's bad enough
that each chunk will require a separate bug IDs. If I were to make the
diamond conversions separate changesets from line joins, it'd require
*two* bug IDs for each chunk.
While I agree there would be some value in keeping these changes in
separate changesets, the sense I get from talking to other folks is
that it isn't worth the additional overhead.
That is my evaluation of this situation.
-Joe
