Kumar Srinivasan wrote:
Hi,
Appreciate a review of the pack200 cleanup work, in the following areas:
1. General generification of Collections.
2. fixed worthy findbugs items.
3. fixed worthy Netbeans nags.
4. Elimination of array/generics combination.
The webrev is here:
http://cr.openjdk.java.net/~ksrini/6990106/webrev.00/
Thanks
Kumar
Kumar - I just scanned this (sorry, I don't have time to do a detailed
review).
- is Attribute.isEmpty right? or rather should ""==null be replaced by
false?
- in BandStructure.java, can basicCodingIndexes be final?
- can Package.getHighestClassVersion use for-each? Same thing in
ClassWriter.writeAttributes.
- the indentation in PackerImpl.java at line 143
- you've renamed locals in several places - is that because they are
hiding fields or something else?
- does the new switch statement in Driver.main need a default? (just
wondering if FindBugs will notice that).
-Alan.
