Le 12/08/2010 20:29, Mandy Chung a écrit :
On 08/11/10 18:26, David Holmes wrote:
I'm a bit behind on this functionality as I have no ideas what a
suppressed exception is. :)
FWIW. The suppressed exceptions are added for automatic resource
management (6911258).
http://mail.openjdk.java.net/pipermail/coin-dev/2009-February/000011.html
That aside I'm curious as to the expected multi-thread usage for an
exception that requires these things to be thread-safe ? Given an
exception occurs in a given thread, passing it to another thread
should require some form of safe-publication.
Agree. May I count you as a reviewer?
http://cr.openjdk.java.net/~mchung/6973831/webrev.02/
Thanks
Mandy
Changes are fine for me.
The "detailMessage" is not final because the VM in fact preallocates
Throwable object (OOME and ArithmeticException) and then sets the
'detailMessage' field directly (as the constructor is not invoked).
I am pretty sure the VM can set this field even if it is declared final.
I think I don't see the problem.
Rémi
