abstractdog commented on PR #8018:
URL: https://github.com/apache/hadoop/pull/8018#issuecomment-3997932494
> @ayushtkn @abstractdog Thank you for your comments. I will follow up on
this PR.
>
> cc: @cnauroth
thanks @slfan1989 ! I just left one more minor comment, also, it's just a
matter of taste, but I feel that the line break is too conservative, leading to
much more line than needed: I usually stick to 120 characters, so unless there
is a specific rule for hadoop, many lines can be merged, e.g.:
```
conf.setClass(YarnConfiguration.TIMELINE_SERVICE_STORE,
MemoryTimelineStore.class, TimelineStore.class);
conf.set(YarnConfiguration.TIMELINE_SERVICE_WEBAPP_ADDRESS,
TIMELINE_SERVICE_WEBAPP_ADDRESS);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
