[
https://issues.apache.org/jira/browse/HADOOP-19779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18060502#comment-18060502
]
ASF GitHub Bot commented on HADOOP-19779:
-----------------------------------------
cnauroth opened a new pull request, #8272:
URL: https://github.com/apache/hadoop/pull/8272
### Description of PR
#8173 used the enforcer plugin to fail fast if trying to build with a JDK
version less than 17. The Maven property declarations for JDK version were
refactored so that they occur in just one place in the root pom.xml. The
create-release script still had a dependency on finding it in
hadoop-project/pom.xml though.
### How was this patch tested?
Attempts to run `create-release` for the 3.5.0 release were failing due to
invalid `JAVA_HOME`, because the version segment in the path was empty. After
applying this fix, the script works.
### For code changes:
- [X] Does the title or this PR starts with the corresponding JIRA issue id
(e.g. 'HADOOP-17799. Your PR title ...')?
- [ ] Object storage: have the integration tests been executed and the
endpoint declared according to the connector-specific documentation?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`,
`NOTICE-binary` files?
### AI Tooling
If an AI tool was used:
- [ ] The PR includes the phrase "Contains content generated by <tool>"
where <tool> is the name of the AI tool used.
- [ ] My use of AI contributions follows the ASF legal policy
https://www.apache.org/legal/generative-tooling.html
> Use enforcer to fail fast if building with Java <17
> ---------------------------------------------------
>
> Key: HADOOP-19779
> URL: https://issues.apache.org/jira/browse/HADOOP-19779
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Reporter: Chris Nauroth
> Assignee: Chris Nauroth
> Priority: Major
> Labels: pull-request-available
> Fix For: 3.5.0
>
>
> Now that trunk has gone to Java 17, we've had some reports of confusion when
> accidentally building with a down-level Java. It goes into the
> hadoop-annotations build and reports the --add-modules compiler option isn't
> recognized, but it doesn't do anything to indicate that root cause is the
> Java version. We can improve on this by updating our enforcer plugin rules to
> check for Java 17+ and fail with an error message clearly pointing out the
> Java version.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
