[
https://issues.apache.org/jira/browse/HADOOP-19685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18019941#comment-18019941
]
ASF GitHub Bot commented on HADOOP-19685:
-----------------------------------------
MikaelSmith opened a new pull request, #7956:
URL: https://github.com/apache/hadoop/pull/7956
### Description of PR
Removes the extra semicolon after an import that causes `-Pclover` to fail
with
com.atlassian.clover.api.CloverException: hadoop/hadoop-tools/
hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/impl/
ITestS3APutIfMatchAndIfNoneMatch.java:43:43:unexpected token: ;`
### How was this patch tested?
```
mvn -e -Pclover install -DskipTests -DskipShade --projects
'hadoop-tools/hadoop-aws'
```
### For code changes:
- [ ] Does the title or this PR starts with the corresponding JIRA issue id
(e.g. 'HADOOP-17799. Your PR title ...')?
- [ ] Object storage: have the integration tests been executed and the
endpoint declared according to the connector-specific documentation?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`,
`NOTICE-binary` files?
> Clover breaks on double semicolon
> ---------------------------------
>
> Key: HADOOP-19685
> URL: https://issues.apache.org/jira/browse/HADOOP-19685
> Project: Hadoop Common
> Issue Type: Task
> Components: hadoop-aws
> Affects Versions: 3.5.0, 3.4.2
> Reporter: Michael Smith
> Assignee: Michael Smith
> Priority: Major
>
> Building with {{-Pclover}} fails with
> {code}
> [INFO] Instrumentation error
> com.atlassian.clover.api.CloverException:
> /home/jenkins/hadoop/hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/impl/ITestS3APutIfMatchAndIfNoneMatch.java:43:43:unexpected
> token: ;
> ...
> Failed to execute goal org.openclover:clover-maven-plugin:4.4.1:setup
> (clover-setup) on project hadoop-aws: Clover has failed to instrument the
> source files in the
> [/home/jenkins/hadoop/hadoop-tools/hadoop-aws/target/clover/src-test-instrumented]
> directory -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute
> goal org.openclover:clover-maven-plugin:4.4.1:setup (clover-setup) on project
> hadoop-aws: Clover has failed to instrument the source files in the
> [/home/jenkins/hadoop/hadoop-tools/hadoop-aws/target/clover/src-test-instrumented]
> directory
> {code}
> It doesn't seem to like a double semicolon in
> ITestS3APutIfMatchAndIfNoneMatch.java that was added in HADOOP-19256.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
