[ https://issues.apache.org/jira/browse/HADOOP-19212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18016423#comment-18016423 ]
ASF GitHub Bot commented on HADOOP-19212: ----------------------------------------- stoty commented on PR #7897: URL: https://github.com/apache/hadoop/pull/7897#issuecomment-3226681187 It's already merged :) I'm fine with this backport. The question whether we want to fully support Java 18+ in 3.4.3. I was working on the assumption that support for Java 18+ was only targeted for 3.5.0. This is just one (admittedly critical) part of support for newer Javas, I alone have more than a dozen Java 25 patches in trunk which were never backported to 3.4, and the large patch for Subject propagation in threads is still WIP. IMO None of those patches are particularly controversial, though backporting them would take some work. The options are: - Hold back 3.4.2 for this patch - Consensus seems to be not do that (and I kind of agree) - Merge just this patch, and release in 3.4.3 - This seems to be enough for at least the Spark tests to pass - Backport full Java 25 support and release in 3.4.3 - This is my preference, as this is the fastest way to unlock the full Hadoop ecosystem for Java 18+ > [JDK23] org.apache.hadoop.security.UserGroupInformation use of Subject needs > to move to replacement APIs > -------------------------------------------------------------------------------------------------------- > > Key: HADOOP-19212 > URL: https://issues.apache.org/jira/browse/HADOOP-19212 > Project: Hadoop Common > Issue Type: Sub-task > Components: security > Affects Versions: 3.5.0 > Reporter: Alan Bateman > Priority: Major > Labels: pull-request-available > > `javax.security.auth.Subject.getSubject` and `Subject.doAs` were deprecated > for removal in JDK 17. The replacement APIs are `Subject.current` and > `callAs`. See [JEP 411]([https://openjdk.org/jeps/411]) for background. > The `Subject.getSubject` API has been "degraded" in JDK 23 to throw > `UnsupportedOperationException` if not running with the option to allow a > SecurityManager. In a future JDK release, the `Subject.getSubject` API will > be degraded further to throw`UnsupportedOperationException` unconditionally. > [renaissance/issues/439]([https://github.com/renaissance-benchmarks/renaissance/issues/439]) > is a failure with a Spark benchmark due to the code in > `org.apache.hadoop.security.UserGroupInformation` using the deprecated > `Subject.getSubject` method. The maintainers of this code need to migrate > this code to the replacement APIs to ensure that this code will continue to > work once the security manager feature is removed. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org