steveloughran commented on code in PR #7738:
URL: https://github.com/apache/hadoop/pull/7738#discussion_r2301169051
##########
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/streams/ObjectReadParameters.java:
##########
@@ -69,6 +70,29 @@ public final class ObjectReadParameters {
*/
private LocalDirAllocator directoryAllocator;
+ /**
+ * Encryption secrets for this stream
Review Comment:
add a . at the end
##########
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/streams/AnalyticsStream.java:
##########
@@ -205,6 +209,12 @@ private OpenStreamInformation
buildOpenStreamInformation(ObjectReadParameters pa
.etag(parameters.getObjectAttributes().getETag()).build());
}
+ if(parameters.getEncryptionSecrets().getEncryptionMethod() ==
S3AEncryptionMethods.SSE_C) {
Review Comment:
nit: add a space before the {
##########
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/ITestS3AEncryptionSSEC.java:
##########
@@ -327,6 +325,65 @@ public void testChecksumRequiresReadAccess() throws
Throwable {
() -> fsKeyB.getFileChecksum(path));
}
+
+ /**
+ * Tests the creation and reading of a file using a different encryption key
+ * when Analytics Accelerator is enabled.
+ *
+ * @throws Exception if any error occurs during the test execution
+ */
+ @Test
+ public void
testCreateFileAndReadWithDifferentEncryptionKeyWithAnalyticsAcceleratorEnabled()
throws Exception {
Review Comment:
rather than do it this way, make the entire test suite (i.e. class)
something which runs with both the normal and accelerated options.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
