anujmodi2021 commented on code in PR #7852:
URL: https://github.com/apache/hadoop/pull/7852#discussion_r2300374528
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsClientThrottlingIntercept.java:
##########
@@ -223,4 +224,18 @@ private static long getContentLengthIfKnown(String range) {
}
return contentLength;
}
+
+ /**
+ * Closes the throttling intercept and releases associated resources.
+ * This method closes both the read and write throttling analyzers.
Review Comment:
Nit: Javadoc to include @ throws
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsNoOpThrottlingIntercept.java:
##########
@@ -40,4 +42,12 @@ public void updateMetrics(final AbfsRestOperationType
operationType,
public void sendingRequest(final AbfsRestOperationType operationType,
final AbfsCounters abfsCounters) {
}
+
+/**
+ * No-op implementation of close method.
Review Comment:
Nit: javadoc to include @ throws
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsClientThrottlingAnalyzer.java:
##########
@@ -172,6 +175,22 @@ public boolean suspendIfNecessary() {
return false;
}
+ /**
+ * Closes the throttling analyzer and releases associated resources.
+ * This method cancels the internal timer and cleans up any pending timer
tasks.
+ * It is safe to call this method multiple times.
Review Comment:
Fix javadoc here a well.
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsThrottlingIntercept.java:
##########
@@ -26,7 +26,7 @@
*/
@InterfaceAudience.Private
@InterfaceStability.Unstable
-public interface AbfsThrottlingIntercept {
+public interface AbfsThrottlingIntercept extends Closable {
Review Comment:
Shouldn't this be extends `Closeable`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
