pan3793 commented on code in PR #7898: URL: https://github.com/apache/hadoop/pull/7898#discussion_r2299802155
########## start-build-env.sh: ########## @@ -93,7 +93,7 @@ RUN userdel -r \$(getent passwd ${USER_ID} | cut -d: -f1) 2>/dev/null || : RUN groupadd --non-unique -g ${GROUP_ID} ${USER_NAME} RUN useradd -g ${GROUP_ID} -u ${USER_ID} -k /root -m ${USER_NAME} -d "${DOCKER_HOME_DIR}" RUN echo "${USER_NAME} ALL=NOPASSWD: ALL" > "/etc/sudoers.d/hadoop-build-${USER_ID}" -ENV HOME "${DOCKER_HOME_DIR}" +ENV HOME="${DOCKER_HOME_DIR}" Review Comment: update because ``` 1 warning found (use docker --debug to expand): - LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 7) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org