Hexiaoqiao commented on code in PR #7845:
URL: https://github.com/apache/hadoop/pull/7845#discussion_r2262328554
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/StandbyCheckpointer.java:
##########
@@ -487,8 +488,9 @@ private void doWork() {
namesystem.setCreatedRollbackImages(true);
namesystem.setNeedRollbackFsImage(false);
}
- lastCheckpointTime = now;
- LOG.info("Checkpoint finished successfully.");
+ lastCheckpointTime = monotonicNow();
Review Comment:
Great catch here. Thanks.
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/StandbyCheckpointer.java:
##########
@@ -459,9 +459,10 @@ private void doWork() {
uncheckpointed, checkpointConf.getTxnCount());
needCheckpoint = true;
} else if (secsSinceLast >= checkpointConf.getPeriod()) {
- LOG.info("Triggering checkpoint because it has been {} seconds " +
- "since the last checkpoint, which exceeds the configured " +
- "interval {}", secsSinceLast, checkpointConf.getPeriod());
+ LOG.info("Triggering checkpoint because it has been {} seconds "
Review Comment:
Please keep the original format.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
