slfan1989 commented on PR #7858: URL: https://github.com/apache/hadoop/pull/7858#issuecomment-3162122354
> Can we move to AssertJ here? > > 1. it's a better syntax, and nicely extensible > 2. it lets us cherrypick into java4 branches without any problems > 3. everyone who has already used it knows the syntax > > I don't want to invest any time learning JUnit5's assert syntax, not given AssertJ is good and I'm still learning the nuances in what is a very powerful assertion language Thank you very much for your feedback! I completely agree with your suggestions. I will make improvements in this PR accordingly. Once the upgrade to JUnit 5 is fully completed, I will create a separate JIRA ticket to batch-convert JUnit 5 assertions to AssertJ. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
