[
https://issues.apache.org/jira/browse/HADOOP-19587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18010950#comment-18010950
]
ASF GitHub Bot commented on HADOOP-19587:
-----------------------------------------
ahmarsuhail commented on code in PR #7738:
URL: https://github.com/apache/hadoop/pull/7738#discussion_r2242908029
##########
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/streams/AnalyticsStream.java:
##########
@@ -205,6 +209,12 @@ private OpenStreamInformation
buildOpenStreamInformation(ObjectReadParameters pa
.etag(parameters.getObjectAttributes().getETag()).build());
}
+ if(parameters.getEncryptionSecrets().getEncryptionMethod() ==
S3AEncryptionMethods.SSE_C) {
Review Comment:
On the GET, you only need it for SSE_C i think, this is what the current S3A
implementation does as well here:
https://github.com/apache/hadoop/blob/636d822682715dbc05af9483e91a9f0ee72f83b8/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/RequestFactoryImpl.java#L639
On writing you need to set it for KMS as well, so the write operation knows
what key to use. Think on the GET, the right key just gets picked up
automatically from KMS.
> S3A Analytics-Accelerator: Add support SSE-C
> --------------------------------------------
>
> Key: HADOOP-19587
> URL: https://issues.apache.org/jira/browse/HADOOP-19587
> Project: Hadoop Common
> Issue Type: Sub-task
> Reporter: Ahmar Suhail
> Priority: Major
> Labels: pull-request-available
>
> Pass down SSE-C key to AAL so it can be attached while making the GET request.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
