[
https://issues.apache.org/jira/browse/HADOOP-19636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18009455#comment-18009455
]
ASF GitHub Bot commented on HADOOP-19636:
-----------------------------------------
pan3793 commented on code in PR #7822:
URL: https://github.com/apache/hadoop/pull/7822#discussion_r2227342002
##########
dev-support/docker/Dockerfile_centos_8:
##########
@@ -1,118 +0,0 @@
-# Licensed to the Apache Software Foundation (ASF) under one
-# or more contributor license agreements. See the NOTICE file
-# distributed with this work for additional information
-# regarding copyright ownership. The ASF licenses this file
-# to you under the Apache License, Version 2.0 (the
-# "License"); you may not use this file except in compliance
-# with the License. You may obtain a copy of the License at
-#
-# http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-
-# Dockerfile for installing the necessary dependencies for building Hadoop.
-# See BUILDING.txt.
-
-FROM centos:8
Review Comment:
> I believe we should completely remove operating systems that have reached
their End of Life (EOL). If we need to support CentOS 9 or Debian 12 in the
future, it should be done by submitting a new PR for a thorough evaluation.
I don't see much benefit in your proposal, I suppose upgrading in place is
straightforward, and can leave clear diff in the commit history to guide users
to understand what they should change for planning Hadoop cluster OS upgrading.
> Rather than maintaining multiple Dockerfiles, I prefer a more lightweight
approach, such as providing support through documentation.
The documentation can easily become outdated (you can try `Building on macOS
(without Docker)` in `BUILDING.txt`). As I replied here, I think the
`Dockerfile` itself is the best documentation for setup the building env.
https://lists.apache.org/thread/2ypqcrnsth3jk21rpjvjv53tntz21ht8
> [JDK17] Remove EOL OS Support and Clean Up Dockerfile.
> ------------------------------------------------------
>
> Key: HADOOP-19636
> URL: https://issues.apache.org/jira/browse/HADOOP-19636
> Project: Hadoop Common
> Issue Type: Sub-task
> Reporter: Shilun Fan
> Assignee: Shilun Fan
> Priority: Major
> Labels: pull-request-available
>
> Removed build support for the following EOL (End-of-Life) operating system
> versions (e.g., CentOS 7, Debian 9, etc.).
> Cleaned up redundant code and dependency configurations in the Dockerfile
> related to these operating systems.
> Optimized the build logic to ensure that currently supported OS versions
> build successfully.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
