[
https://issues.apache.org/jira/browse/HADOOP-19415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17950813#comment-17950813
]
ASF GitHub Bot commented on HADOOP-19415:
-----------------------------------------
slfan1989 commented on code in PR #7419:
URL: https://github.com/apache/hadoop/pull/7419#discussion_r2083686539
##########
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/contract/localfs/TestLocalFSContractLoaded.java:
##########
@@ -38,16 +38,16 @@ protected AbstractFSContract createContract(Configuration
conf) {
@Test
public void testContractWorks() throws Throwable {
String key = getContract().getConfKey(SUPPORTS_ATOMIC_RENAME);
- assertNotNull("not set: " + key, getContract().getConf().get(key));
- assertTrue("not true: " + key,
- getContract().isSupported(SUPPORTS_ATOMIC_RENAME, false));
+ assertNotNull(getContract().getConf().get(key), "not set: " + key);
+ assertTrue(getContract().isSupported(SUPPORTS_ATOMIC_RENAME, false),
+ "not true: " + key);
}
@Test
public void testContractResourceOnClasspath() throws Throwable {
URL url = this.getClass()
.getClassLoader()
.getResource(LocalFSContract.CONTRACT_XML);
- assertNotNull("could not find contract resource", url);
+ assertNotNull(url, "could not find contract resource");
}
}
Review Comment:
I will improve this part of the code.
> Upgrade JUnit from 4 to 5 in hadoop-common.
> -------------------------------------------
>
> Key: HADOOP-19415
> URL: https://issues.apache.org/jira/browse/HADOOP-19415
> Project: Hadoop Common
> Issue Type: Sub-task
> Reporter: Shilun Fan
> Assignee: Shilun Fan
> Priority: Major
> Labels: pull-request-available
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
