steveloughran commented on code in PR #7592:
URL: https://github.com/apache/hadoop/pull/7592#discussion_r2035938447
##########
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/S3ATestUtils.java:
##########
@@ -1709,6 +1710,24 @@ public static void skipIfEncryptionNotSet(Configuration
configuration,
}
}
+ /**
+ * Skip a test if encryption algorithm is not empty, or if it is set to
anything other than AES256.
+ *
+ * @param configuration configuration
+ * @throws IOException if the secret lookup fails.
+ */
+ public static void skipIfEncryptionSet(Configuration configuration) throws
IOException {
Review Comment:
change title to skipForAnyEncryptionExceptSSES3()
##########
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/contract/s3a/ITestS3AContractAnalyticsStreamVectoredRead.java:
##########
@@ -44,6 +48,19 @@ public ITestS3AContractAnalyticsStreamVectoredRead(String
bufferType) {
protected Configuration createConfiguration() {
Configuration conf = super.createConfiguration();
enableAnalyticsAccelerator(conf);
+
+ // If encryption is set, some AAL tests will fail. This is because AAL
caches the head request response, and uses
+ // the eTag when making a GET request. When using encryption, the eTag is
no longer a hash of the object content,
+ // and is not always the same when the same object is created multiple
times. This test creates the file
+ // vectored_file.txt before running each test, which will have a different
eTag when using encryption, leading to
+ // preconditioned failures. This issue is tracked in:
+ // https://github.com/awslabs/analytics-accelerator-s3/issues/218
+ try {
+ skipIfEncryptionSet(conf);
+ } catch (IOException e) {
Review Comment:
do this in the method itself
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
