slfan1989 commented on code in PR #7533:
URL: https://github.com/apache/hadoop/pull/7533#discussion_r2023883068
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/router/TestRouterNetworkTopologyServlet.java:
##########
@@ -204,7 +279,41 @@ public void testPrintTopologyNoDatanodesJsonFormat()
throws Exception {
sb.append("\n-- Network Topology -- ");
String topology = sb.toString();
- // assert node number
+ // Assert node number.
assertTrue(topology.contains("No DataNodes"));
}
}
+
+class RouterServerHelper implements BeforeEachCallback, AfterAllCallback {
Review Comment:
"I believe the current changes in this PR are acceptable, but it would be
better to extract `RouterServerHelper` to avoid potential code redundancy.
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/router/TestRouterNetworkTopologyServlet.java:
##########
@@ -204,7 +279,41 @@ public void testPrintTopologyNoDatanodesJsonFormat()
throws Exception {
sb.append("\n-- Network Topology -- ");
String topology = sb.toString();
- // assert node number
+ // Assert node number.
assertTrue(topology.contains("No DataNodes"));
}
}
+
+class RouterServerHelper implements BeforeEachCallback, AfterAllCallback {
Review Comment:
I believe the current changes in this PR are acceptable, but it would be
better to extract `RouterServerHelper` to avoid potential code redundancy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
