cnauroth commented on code in PR #7363:
URL: https://github.com/apache/hadoop/pull/7363#discussion_r1947474810
##########
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapreduce/lib/output/TestPathOutputCommitterFactory.java:
##########
@@ -156,9 +156,9 @@ public void testNamedCommitterFactory() throws Throwable {
SimpleCommitter sc = createCommitter(
NamedCommitterFactory.class,
SimpleCommitter.class, HDFS_PATH, conf);
- assertEquals("Wrong output path from " + sc,
- HDFS_PATH,
- sc.getOutputPath());
+ assertEquals(
+ HDFS_PATH
+, sc.getOutputPath(), "Wrong output path from " + sc);
Review Comment:
Odd formatting here?
##########
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/contract/AbstractFSContractTestBase.java:
##########
@@ -250,6 +250,20 @@ protected Path methodPath() throws IOException {
return path(methodName.getMethodName());
}
+ /**
+ * Get a path whose name ends with the name of this method.
+ *
+ * This is a temporary requirement for upgrading from JUnit 4 to JUnit 5,
+ * and can be deleted later.
+ *
+ * @param name name of this method.
+ * @return a path implicitly unique amongst all methods in this class
+ * @throws IOException IO problems
+ */
+ protected Path methodPath(String name) throws IOException {
Review Comment:
I'm unclear, is anything actually calling this method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
