[
https://issues.apache.org/jira/browse/HADOOP-19415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17923887#comment-17923887
]
ASF GitHub Bot commented on HADOOP-19415:
-----------------------------------------
slfan1989 commented on PR #7347:
URL: https://github.com/apache/hadoop/pull/7347#issuecomment-2635526163
> `TestViewFSOverloadSchemeCentralMountTableConfig` is a subclass of
`TestViewFileSystemOverloadSchemeLocalFileSystem`. In your patch, the base
class has been converted to JUnit 5 with the Jupiter annotations. The subclass
though is still using `org.junit.Before`, so maybe its test setup is not
getting triggered. Do we need to convert that one to
`org.junit.jupiter.api.BeforeEach`?
@cnauroth Thank you very much for reviewing the code! This is an issue we
are already aware of—there are some abstract test classes in hadoop-common that
are used by multiple modules, such as hadoop-azure, hadoop-aws, hadoop-distcp,
etc. Our plan is to first upgrade the parts without dependencies, and then
submit a unified PR to handle the dependent parts. To ensure this PR passes the
build, I plan to roll back the changes to
TestViewFSOverloadSchemeCentralMountTableConfig. Additionally, I will fix the
checkstyle and blank issues. We hope that the feedback from Yetus will be
positive, and the build will pass successfully.
> Upgrade JUnit from 4 to 5 in hadoop-common.
> -------------------------------------------
>
> Key: HADOOP-19415
> URL: https://issues.apache.org/jira/browse/HADOOP-19415
> Project: Hadoop Common
> Issue Type: Sub-task
> Reporter: Shilun Fan
> Assignee: Shilun Fan
> Priority: Major
> Labels: pull-request-available
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
