[ 
https://issues.apache.org/jira/browse/HADOOP-19415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17922976#comment-17922976
 ] 

ASF GitHub Bot commented on HADOOP-19415:
-----------------------------------------

cnauroth commented on code in PR #7339:
URL: https://github.com/apache/hadoop/pull/7339#discussion_r1938321130


##########
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfiguration.java:
##########
@@ -2557,11 +2546,11 @@ public void testGettingPropertiesWithPrefix() throws 
Exception {
     assertTrue(prefixedProps.isEmpty());
   }
 
-  public static void main(String[] argv) throws Exception {
+  /*public static void main(String[] argv) throws Exception {

Review Comment:
   Could this not be translated to JUnit 5?
   
   I'm actually not sure if it's valuable anyway. If it's not needed, let's 
delete it instead of commenting it out.





> Upgrade JUnit from 4 to 5 in hadoop-common.
> -------------------------------------------
>
>                 Key: HADOOP-19415
>                 URL: https://issues.apache.org/jira/browse/HADOOP-19415
>             Project: Hadoop Common
>          Issue Type: Sub-task
>            Reporter: Shilun Fan
>            Assignee: Shilun Fan
>            Priority: Major
>              Labels: pull-request-available
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to