rajdchak commented on code in PR #7295:
URL: https://github.com/apache/hadoop/pull/7295#discussion_r1922681772
##########
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/S3AStoreImpl.java:
##########
@@ -230,7 +232,23 @@ public class S3AStoreImpl
@Override
protected void serviceInit(final Configuration conf) throws Exception {
- objectInputStreamFactory = createStreamFactory(conf);
+ if(conf.getBoolean(ANALYTICS_ACCELERATOR_ENABLED_KEY,
ANALYTICS_ACCELERATOR_ENABLED_DEFAULT)) {
Review Comment:
Our S3SeekableInputStreamFactory requires s3AsyncClient to be passed in the
constructor S3SeekableInputStreamFactory(S3AsyncClient s3AsyncClient) {
super("S3SeekableInputStreamFactory");
this.s3AsyncClient = s3AsyncClient;
}
I couldn't create that in the InputStreamType enum that Steve made, so kept
it this way for now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
