[
https://issues.apache.org/jira/browse/HADOOP-19232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17911913#comment-17911913
]
ASF GitHub Bot commented on HADOOP-19232:
-----------------------------------------
anmolanmol1234 commented on code in PR #7272:
URL: https://github.com/apache/hadoop/pull/7272#discussion_r1910172107
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsOutputStream.java:
##########
@@ -376,31 +576,15 @@ private void failureWhileSubmit(Exception ex) throws
IOException {
throw lastError;
}
- /**
- * Synchronized accessor to the active block.
- *
- * @return the active block; null if there isn't one.
- */
- private synchronized DataBlocks.DataBlock getActiveBlock() {
- return activeBlock;
- }
-
- /**
- * Predicate to query whether or not there is an active block.
- *
- * @return true if there is an active block.
- */
- private synchronized boolean hasActiveBlock() {
- return activeBlock != null;
- }
-
/**
* Is there an active block and is there any data in it to upload?
*
* @return true if there is some data to upload in an active block else
false.
*/
- private boolean hasActiveBlockDataToUpload() {
- return hasActiveBlock() && getActiveBlock().hasData();
+ boolean hasActiveBlockDataToUpload() {
+ AzureBlockManager blockManager = getBlockManager();
+ AbfsBlock activeBlock = blockManager.getActiveBlock();
+ return blockManager.hasActiveBlock() && activeBlock.hasData();
Review Comment:
hasActiveBlock checks for null for activeBlock and blockManager can not be
null
> ABFS: [FnsOverBlob] Implementing Ingress Support with various Fallback
> Handling
> -------------------------------------------------------------------------------
>
> Key: HADOOP-19232
> URL: https://issues.apache.org/jira/browse/HADOOP-19232
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/azure
> Affects Versions: 3.4.0
> Reporter: Descifrado
> Assignee: Anmol Asrani
> Priority: Major
> Labels: pull-request-available
>
> Scope of this task is to refactor the AbfsOutputStream class to handle the
> ingress for DFS and Blob endpoint effectively.
> More details will be added soon.
> Perquisites for this Patch:
> 1. [HADOOP-19187] ABFS: [FnsOverBlob]Making AbfsClient Abstract for
> supporting both DFS and Blob Endpoint - ASF JIRA (apache.org)
> 2. [HADOOP-19226] ABFS: [FnsOverBlob]Implementing Azure Rest APIs on Blob
> Endpoint for AbfsBlobClient - ASF JIRA (apache.org)
> 3. [HADOOP-19207] ABFS: [FnsOverBlob]Response Handling of Blob Endpoint APIs
> and Metadata APIs - ASF JIRA (apache.org)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
