EungsopYoo commented on code in PR #7168:
URL: https://github.com/apache/hadoop/pull/7168#discussion_r1847443009
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/ElasticByteBufferPool.java:
##########
@@ -36,7 +36,7 @@
*/
@InterfaceAudience.Public
@InterfaceStability.Stable
-public class ElasticByteBufferPool implements ByteBufferPool {
+public abstract class ElasticByteBufferPool implements ByteBufferPool {
Review Comment:
I have tested it; just replace the class, compile with no error, run the
binary, and watch it works as I expected(no direct memory leakage).
But it requires a new test case. I will add some.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
