[
https://issues.apache.org/jira/browse/HADOOP-19287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17884269#comment-17884269
]
ASF GitHub Bot commented on HADOOP-19287:
-----------------------------------------
ayushtkn commented on code in PR #7068:
URL: https://github.com/apache/hadoop/pull/7068#discussion_r1773302719
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/crypto/key/kms/KMSClientProvider.java:
##########
@@ -178,7 +178,7 @@ public static class KMSTokenRenewer extends TokenRenewer {
@Override
public boolean handleKind(Text kind) {
- return kind.equals(TOKEN_KIND);
+ return kind.equals(KMSDelegationToken.TOKEN_KIND);
Review Comment:
``TOKEN_KIND`` is storing the same value in the same class how things change
by not using the variable
```
public static final Text TOKEN_KIND = KMSDelegationToken.TOKEN_KIND;
```
> Fix KMSTokenRenewer#handleKind dependency on BouncyCastleProvider class
> -----------------------------------------------------------------------
>
> Key: HADOOP-19287
> URL: https://issues.apache.org/jira/browse/HADOOP-19287
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: dzcxzl
> Priority: Major
> Labels: pull-request-available
>
>
> {code:java}
> Exception in thread "main" java.lang.NoClassDefFoundError:
> org/bouncycastle/jce/provider/BouncyCastleProvider
> at
> org.apache.hadoop.crypto.key.kms.KMSClientProvider$KMSTokenRenewer.handleKind(KMSClientProvider.java:180)
> at org.apache.hadoop.security.token.Token.getRenewer(Token.java:467)
> at org.apache.hadoop.security.token.Token.renew(Token.java:500)
> at
> org.apache.spark.deploy.security.HadoopFSDelegationTokenProvider.$anonfun$getTokenRenewalInterval$3(HadoopFSDelegationTokenProvider.scala:147)
> at scala.runtime.java8.JFunction0$mcJ$sp.apply(JFunction0$mcJ$sp.scala:17)
> at scala.util.Try$.apply(Try.scala:217)
> at
> org.apache.spark.deploy.security.HadoopFSDelegationTokenProvider.$anonfun$getTokenRenewalInterval$2(HadoopFSDelegationTokenProvider.scala:146)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
