ayushtkn commented on code in PR #6307:
URL: https://github.com/apache/hadoop/pull/6307#discussion_r1769487525
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/web/DatanodeHttpServer.java:
##########
@@ -144,7 +147,16 @@ public DatanodeHttpServer(final Configuration conf,
confForCreate.set(FsPermission.UMASK_LABEL, "000");
this.bossGroup = new NioEventLoopGroup();
- this.workerGroup = new NioEventLoopGroup();
+ int workerCount = conf.getInt(DFS_DATANODE_NETTY_WORKER_NUM_THREADS_KEY,
+ DFS_DATANODE_NETTY_WORKER_NUM_THREADS_DEFAULT);
+ if (workerCount < 0) {
+ LOG.warn("The value of " +
+ DFS_DATANODE_NETTY_WORKER_NUM_THREADS_KEY + " is less than 0, will
use default value: " +
+ DFS_DATANODE_NETTY_WORKER_NUM_THREADS_DEFAULT);
+ workerCount = DFS_DATANODE_NETTY_WORKER_NUM_THREADS_DEFAULT;
Review Comment:
you logger format {} instead of concat
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
