steveloughran commented on PR #7048:
URL: https://github.com/apache/hadoop/pull/7048#issuecomment-2360899909

   > And then testNoisyLogging will start failing. So then do we revert or fix 
the test?
   
   the test failure will be how we verify that all is good. at which point we 
can modify the test to fail if any warnings come from the manager.
   
   > I think we want to disable transfer manager logs permanently, so it'll 
just be fixing the test.
   
   I'm going to propose moving off it entirely
   * too opaque
   * different client hurts startup and teardown. lazy start is insufficient
   * using the existing thread an http pools is more efficient and should be 
more responsive
   * we can't add audit headers to all requests
   * for If-none-match headers, doing it in our own code ensures it is present 
*and* we can generate genuine conflicts of file deletion and creation during a 
multipart rename.
   
   also I no longer trust the code.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to