[
https://issues.apache.org/jira/browse/HADOOP-19165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17882602#comment-17882602
]
ASF GitHub Bot commented on HADOOP-19165:
-----------------------------------------
ayushtkn opened a new pull request, #7051:
URL: https://github.com/apache/hadoop/pull/7051
### Description of PR
Drop protobuf 2.5.0 from the distribution, Hadoop uses the one from
hadoop-thirdparty, we ideally don't need it.
### How was this patch tested?
Manually
**1. The contents of the distro:**
**Before:**
```
ayushsaxena@ayushsaxena share % ls -l -R . | grep protobuf
-rw-r--r--@ 1 ayushsaxena staff 1952718 Sep 18 10:54
hadoop-shaded-protobuf_3_25-1.3.0.jar
-rw-r--r--@ 1 ayushsaxena staff 1952718 Sep 18 10:56
hadoop-shaded-protobuf_3_25-1.3.0.jar
-rw-r--r--@ 1 ayushsaxena staff 5105 Sep 18 10:16
grpc-protobuf-1.53.0.jar
-rw-r--r--@ 1 ayushsaxena staff 7555 Sep 18 10:16
grpc-protobuf-lite-1.53.0.jar
-rw-r--r--@ 1 ayushsaxena staff 1875927 Sep 18 10:16
hbase-shaded-protobuf-4.1.5.jar
-rw-r--r--@ 1 ayushsaxena staff 533455 Sep 18 10:16
protobuf-java-2.5.0.jar
```
**Now:**
```
ayushsaxena@ayushsaxena share % ls -l -R . | grep protobuf
-rw-r--r--@ 1 ayushsaxena staff 1952718 Sep 18 12:43
hadoop-shaded-protobuf_3_25-1.3.0.jar
-rw-r--r--@ 1 ayushsaxena staff 1952718 Sep 18 12:44
hadoop-shaded-protobuf_3_25-1.3.0.jar
-rw-r--r--@ 1 ayushsaxena staff 5105 Sep 18 12:48
grpc-protobuf-1.53.0.jar
-rw-r--r--@ 1 ayushsaxena staff 7555 Sep 18 12:48
grpc-protobuf-lite-1.53.0.jar
-rw-r--r--@ 1 ayushsaxena staff 1875927 Sep 18 12:48
hbase-shaded-protobuf-4.1.5.jar
```
No protbuf-java-2.5.0 now in the distro
**2. Maven dependency:tree**
**Before:**
```
ayushsaxena@ayushsaxena hadoop % mvn dependency:tree | grep
protobuf-java:jar:2.5.0:compile
[INFO] | +- com.google.protobuf:protobuf-java:jar:2.5.0:compile
[INFO] | +- com.google.protobuf:protobuf-java:jar:2.5.0:compile
[INFO] | +- com.google.protobuf:protobuf-java:jar:2.5.0:compile
[INFO] | | +- com.google.protobuf:protobuf-java:jar:2.5.0:compile
ayushsaxena@ayushsaxena hadoop %
```
**Now:**
```
ayushsaxena@ayushsaxena hadoop % mvn dependency:tree | grep
protobuf-java:jar:2.5.0:compile
ayushsaxena@ayushsaxena hadoop %
```
Ran some UT selectively, Waiting for the CI to report any errors, if any
### For code changes:
- [x] Does the title or this PR starts with the corresponding JIRA issue id
(e.g. 'HADOOP-17799. Your PR title ...')?
- [ ] Object storage: have the integration tests been executed and the
endpoint declared according to the connector-specific documentation?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`,
`NOTICE-binary` files?
> Explore dropping protobuf 2.5.0 from the distro
> -----------------------------------------------
>
> Key: HADOOP-19165
> URL: https://issues.apache.org/jira/browse/HADOOP-19165
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Ayush Saxena
> Priority: Major
>
> explore if protobuf-2.5.0 can be dropped from distro, it is a transitive
> dependency from HBase, but HBase doesn't use it in the code.
> Check if it is the only one pulling it into the distro & will something break
> if we exclude that, if none lets get rid of it
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
