pjfanning commented on PR #6692: URL: https://github.com/apache/hadoop/pull/6692#issuecomment-2294159706
> I still see some usage of StringBuffer in the code, is that intentional? We just want to replace in couple of places? <img alt="image" width="1411" src="https://private-user-images.githubusercontent.com/25608848/358703021-3a82ba2a-62ff-4db4-8b40-c915d7ed5887.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjM4MzkwNTAsIm5iZiI6MTcyMzgzODc1MCwicGF0aCI6Ii8yNTYwODg0OC8zNTg3MDMwMjEtM2E4MmJhMmEtNjJmZi00ZGI0LThiNDAtYzkxNWQ3ZWQ1ODg3LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MTYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODE2VDIwMDU1MFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTk5YTRmM2NlZDNiNjNiMWEyMGQzZjRmYmM2YzhhNGY2NGYxNjc2MjlhZTY5OGQ0OWNjMDAwYzQ4MDQ4MWZkNzImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.9wW9pXM29cilCiocZTA_1FL_IfHNepQXQXjLwQ1p0yk";> I didn't focus too much on the test code because I wanted to keep the size of the PR down. There are also a few places where StringBuffer is required by the APIs that are used. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
![https://private-user-images.githubusercontent.com/25608848/358703021-3a82ba2a-62ff-4db4-8b40-c915d7ed5887.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjM4MzkwNTAsIm5iZiI6MTcyMzgzODc1MCwicGF0aCI6Ii8yNTYwODg0OC8zNTg3MDMwMjEtM2E4MmJhMmEtNjJmZi00ZGI0LThiNDAtYzkxNWQ3ZWQ1ODg3LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MTYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODE2VDIwMDU1MFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTk5YTRmM2NlZDNiNjNiMWEyMGQzZjRmYmM2YzhhNGY2NGYxNjc2MjlhZTY5OGQ0OWNjMDAwYzQ4MDQ4MWZkNzImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.9wW9pXM29cilCiocZTA_1FL_IfHNepQXQXjLwQ1p0yk"](https://private-user-images.githubusercontent.com/25608848/358703021-3a82ba2a-62ff-4db4-8b40-c915d7ed5887.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjM4MzkwNTAsIm5iZiI6MTcyMzgzODc1MCwicGF0aCI6Ii8yNTYwODg0OC8zNTg3MDMwMjEtM2E4MmJhMmEtNjJmZi00ZGI0LThiNDAtYzkxNWQ3ZWQ1ODg3LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MTYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODE2VDIwMDU1MFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTk5YTRmM2NlZDNiNjNiMWEyMGQzZjRmYmM2YzhhNGY2NGYxNjc2MjlhZTY5OGQ0OWNjMDAwYzQ4MDQ4MWZkNzImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.9wW9pXM29cilCiocZTA_1FL_IfHNepQXQXjLwQ1p0yk"){kind=link}